Skip to content

fix(themes): Add tslib and @clerk/types as dependencies to @clerk/themes #2665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

macalinao
Copy link
Contributor

Description

There is an issue with Yarn PNP requiring a package extension to safely resolve @clerk/themes. This patch resolves this issue.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

Copy link

changeset-bot bot commented Jan 26, 2024

⚠️ No Changeset found

Latest commit: f955b75

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@r4zendev
Copy link

r4zendev commented Mar 6, 2024

This would solve build issues that we are having in our nextjs application. Build sometimes passes and sometimes fails, completely randomly.
Installing tslib as a separate dependency in the same application does not solve the issue. Also, there is no way to tell our package manager (pnpm) that this package requires this library, because it's not specified in peerDependencies. If it was the other way, we could at least try to hack this using auto-install-peers option. Either way, it seems like it's not a simple problem to solve and needs to be addressed by the clerk team.
Any ETA on when this can be reviewed?

@nikosdouvlis
Copy link
Member

This makes sense to me, @macalinao thanks for your contribution :)

@nikosdouvlis nikosdouvlis merged commit ce0b68e into clerk:main Mar 12, 2024
LekoArts pushed a commit that referenced this pull request Mar 13, 2024
LekoArts added a commit that referenced this pull request Mar 13, 2024
…mes (#2665) (#2987)

* fix(themes): Add tslib and @clerk/types as dependencies to @clerk/themes (#2665)

(cherry picked from commit ce0b68e)

* Create selfish-mugs-love.md

* chore(themes): Revert unrelated change

* chore(repo): Reset lock file

* chore(repo): Update lock file

---------

Co-authored-by: Ian Macalinao <[email protected]>
@dimkl
Copy link
Contributor

dimkl commented Mar 13, 2024

@macalinao you have released @clerk/[email protected] with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants