Skip to content

chore(clerk-expo): Update dependencies #2938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 8, 2024
Merged

chore(clerk-expo): Update dependencies #2938

merged 4 commits into from
Mar 8, 2024

Conversation

octoper
Copy link
Member

@octoper octoper commented Mar 5, 2024 •
edited
Loading

Description

This PR updates some of @clerk/clerk-expo dependencies

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 5, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: cca6ab3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@octoper
Copy link
Member Author

octoper commented Mar 5, 2024

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @octoper - the snapshot version command generated the following package versions:

Package Version
@clerk/backend 1.0.1-snapshot.v23fcf68
@clerk/chrome-extension 1.0.1-snapshot.v23fcf68
@clerk/clerk-js 5.0.1-snapshot.v23fcf68
@clerk/clerk-expo 1.0.1-snapshot.v23fcf68
@clerk/fastify 1.0.1-snapshot.v23fcf68
gatsby-plugin-clerk 5.0.1-snapshot.v23fcf68
@clerk/localizations 2.0.1-snapshot.v23fcf68
@clerk/nextjs 5.0.1-snapshot.v23fcf68
@clerk/clerk-react 5.0.1-snapshot.v23fcf68
@clerk/remix 4.0.1-snapshot.v23fcf68
@clerk/clerk-sdk-node 5.0.1-snapshot.v23fcf68
@clerk/shared 2.0.1-snapshot.v23fcf68
@clerk/themes 2.0.1-snapshot.v23fcf68
@clerk/types 4.0.1-snapshot.v23fcf68

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/backend

npm i @clerk/[email protected] --save-exact

@clerk/chrome-extension

npm i @clerk/[email protected] --save-exact

@clerk/clerk-js

npm i @clerk/[email protected] --save-exact

@clerk/clerk-expo

npm i @clerk/[email protected] --save-exact

@clerk/fastify

npm i @clerk/[email protected] --save-exact

gatsby-plugin-clerk

npm i [email protected] --save-exact

@clerk/localizations

npm i @clerk/[email protected] --save-exact

@clerk/nextjs

npm i @clerk/[email protected] --save-exact

@clerk/clerk-react

npm i @clerk/[email protected] --save-exact

@clerk/remix

npm i @clerk/[email protected] --save-exact

@clerk/clerk-sdk-node

npm i @clerk/[email protected] --save-exact

@clerk/shared

npm i @clerk/[email protected] --save-exact

@clerk/themes

npm i @clerk/[email protected] --save-exact

@clerk/types

npm i @clerk/[email protected] --save-exact

@octoper octoper force-pushed the vaggelis/sdk-1418-expo-50-compatibility branch from 23fcf68 to 498dc07 Compare March 6, 2024 15:54
@octoper
Copy link
Member Author

octoper commented Mar 6, 2024

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @octoper - the snapshot version command generated the following package versions:

Package Version
@clerk/backend 1.0.1-snapshot.v498dc07
@clerk/chrome-extension 1.0.1-snapshot.v498dc07
@clerk/clerk-js 5.0.1-snapshot.v498dc07
@clerk/clerk-expo 1.0.1-snapshot.v498dc07
@clerk/fastify 1.0.1-snapshot.v498dc07
gatsby-plugin-clerk 5.0.1-snapshot.v498dc07
@clerk/localizations 2.0.1-snapshot.v498dc07
@clerk/nextjs 5.0.1-snapshot.v498dc07
@clerk/clerk-react 5.0.1-snapshot.v498dc07
@clerk/remix 4.0.1-snapshot.v498dc07
@clerk/clerk-sdk-node 5.0.1-snapshot.v498dc07
@clerk/shared 2.0.1-snapshot.v498dc07
@clerk/themes 2.0.1-snapshot.v498dc07
@clerk/types 4.0.1-snapshot.v498dc07

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/backend

npm i @clerk/[email protected] --save-exact

@clerk/chrome-extension

npm i @clerk/[email protected] --save-exact

@clerk/clerk-js

npm i @clerk/[email protected] --save-exact

@clerk/clerk-expo

npm i @clerk/[email protected] --save-exact

@clerk/fastify

npm i @clerk/[email protected] --save-exact

gatsby-plugin-clerk

npm i [email protected] --save-exact

@clerk/localizations

npm i @clerk/[email protected] --save-exact

@clerk/nextjs

npm i @clerk/[email protected] --save-exact

@clerk/clerk-react

npm i @clerk/[email protected] --save-exact

@clerk/remix

npm i @clerk/[email protected] --save-exact

@clerk/clerk-sdk-node

npm i @clerk/[email protected] --save-exact

@clerk/shared

npm i @clerk/[email protected] --save-exact

@clerk/themes

npm i @clerk/[email protected] --save-exact

@clerk/types

npm i @clerk/[email protected] --save-exact

@octoper octoper force-pushed the vaggelis/sdk-1418-expo-50-compatibility branch from 498dc07 to 900a5e0 Compare March 6, 2024 18:23
@octoper octoper changed the title chore(clerk-expo): Expo v50 support chore(clerk-expo): Update dependencies Mar 6, 2024
@octoper octoper marked this pull request as ready for review March 6, 2024 18:23
@octoper octoper requested a review from anagstef March 7, 2024 17:12
@octoper octoper assigned panteliselef and octoper and unassigned panteliselef Mar 7, 2024
@octoper octoper requested review from panteliselef and LekoArts March 7, 2024 17:12
@octoper octoper force-pushed the vaggelis/sdk-1418-expo-50-compatibility branch 2 times, most recently from f124b1e to 0957a5d Compare March 7, 2024 18:03
nikosdouvlis
nikosdouvlis approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@nikosdouvlis nikosdouvlis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at Lennart's comment and then you're good to go :)

@octoper octoper force-pushed the vaggelis/sdk-1418-expo-50-compatibility branch from 0957a5d to 2a68def Compare March 8, 2024 10:37
LekoArts
LekoArts approved these changes Mar 8, 2024
View reviewed changes
@octoper octoper force-pushed the vaggelis/sdk-1418-expo-50-compatibility branch from ffa6aad to cca6ab3 Compare March 8, 2024 13:43
@octoper octoper enabled auto-merge March 8, 2024 13:43
@octoper octoper added this pull request to the merge queue Mar 8, 2024
Merged via the queue into main with commit ee20754 Mar 8, 2024
@octoper octoper deleted the vaggelis/sdk-1418-expo-50-compatibility branch March 8, 2024 14:02
@clerk-cookie clerk-cookie mentioned this pull request Mar 8, 2024
Merged
dimkl
dimkl reviewed Mar 11, 2024
View reviewed changes
packages/expo/package.json
"expo-web-browser": "^12.3.2",
"tslib": "^2.3.1",
"expo-auth-session": "^5.4.0",
"expo-web-browser": "^12.8.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Shouldn't we move those dependencies to dependencies instead of dev since they are being used in our code execution, not only in the build or development step of this package?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah you are right, we should also do that with tslib

Copy link
Member Author

@octoper octoper Mar 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry scratch the above, these are included in peerDependencies

@dimkl
Copy link
Contributor

dimkl commented Mar 11, 2024 •
edited
Loading

❓ Why did bump those dependencies?

  • We had to bump the expo-web-browser to at least 12.5.0 for expo@v50 to work (ref)
  • We could possible revert the expo-auth-session bump since it does not seem to break expo@v50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimkl dimkl dimkl left review comments

@nikosdouvlis nikosdouvlis nikosdouvlis approved these changes

@LekoArts LekoArts LekoArts approved these changes

@desiprisg desiprisg desiprisg approved these changes

@anagstef anagstef Awaiting requested review from anagstef

@panteliselef panteliselef Awaiting requested review from panteliselef

Assignees

@octoper octoper

Labels
expo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@octoper @clerk-cookie @dimkl @nikosdouvlis @LekoArts @desiprisg @panteliselef