Skip to content

fix(clerk-js): Fix the input box-shadow on iOS 16 devices #2946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

anagstef
Copy link
Member

@anagstef anagstef commented Mar 7, 2024

Description

This PR addresses an issue in iOS Webkit for iOS versions <=16.x with the box-shadow on input elements.
We added the -webkit-appearance: none to all the input elements.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Mar 7, 2024

🦋 Changeset detected

Latest commit: 70a2785

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@anagstef
Copy link
Member Author

anagstef commented Mar 7, 2024

!preview

@anagstef anagstef force-pushed the stefanos/sdk-1463-issues-with-input-borders-on-ios-1675-and-might-be-also-on branch from ae1c5cd to 70a2785 Compare March 7, 2024 11:33
@anagstef
Copy link
Member Author

anagstef commented Mar 7, 2024

!preview

@clerk-cookie
Copy link
Collaborator

clerk-cookie commented Mar 7, 2024

Hey @anagstef, your preview is available.

Status Preview Updated (UTC)
🍪 Deployed Visit preview Mar 07, 2024 11:37 AM

@anagstef anagstef marked this pull request as ready for review March 7, 2024 12:05
@anagstef anagstef requested review from octoper and desiprisg March 7, 2024 12:05
@anagstef anagstef self-assigned this Mar 7, 2024
@nikosdouvlis nikosdouvlis merged commit 141f09f into main Mar 7, 2024
@nikosdouvlis nikosdouvlis deleted the stefanos/sdk-1463-issues-with-input-borders-on-ios-1675-and-might-be-also-on branch March 7, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants