Skip to content

fix(remix): Fix issues caused by modifying duplex on Request #3645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2024
Merged

fix(remix): Fix issues caused by modifying duplex on Request #3645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05d1b01
fix(remix): Fix issues caused by modifying duplex on Request
octoper Jul 1, 2024
c9e1f36
chore(repo): Update changeset
octoper Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tall-hairs-dream.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@clerk/remix": patch
---

Fix issues caused by modifying duplex property on Request when it was already defined
3 changes: 2 additions & 1 deletion packages/remix/src/ssr/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,8 @@ export const wrapWithClerkState = (data: any) => {
*/
export const patchRequest = (request: Request) => {
const clonedRequest = request.clone();
if (clonedRequest.method !== 'GET' && clonedRequest.body !== null) {
// If duplex is not set, set it to 'half' to avoid duplex issues with unidici
if (clonedRequest.method !== 'GET' && clonedRequest.body !== null && !('duplex' in clonedRequest)) {
(clonedRequest as unknown as { duplex: 'half' }).duplex = 'half';
}
return clonedRequest;
Expand Down
Loading