Skip to content

(bs/to-byte-array []) fails #19

Open
@martinraison

Description

@martinraison

Is this by design? I would expect to get an empty byte array instead.

=> (bs/to-byte-array [])
IllegalArgumentException Don't know how to convert class clojure.lang.PersistentVector into class [B byte-streams/convert (byte_streams.clj:187)

Since (bs/to-byte-array [(byte-array [2 3 4]) (byte-array [5 6])]) works, the behavior seems surprising to me. It requires checking that the array is not empty before calling to-byte-array.

Activity

ztellman

ztellman commented on Aug 13, 2015

@ztellman
Collaborator

Currently byte-streams doesn't handle nil or empty sequences, mostly because I haven't thought through all the implications of (for instance) implicitly transforming nil into an empty byte-array. I agree, though, that it puts an unfortunate burden on you. Leaving this issue open until I have a better answer.

martinraison

martinraison commented on Aug 14, 2015

@martinraison
Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @ztellman@martinraison

        Issue actions

          (bs/to-byte-array []) fails · Issue #19 · clj-commons/byte-streams