CLJS-3332: improperly indexed Node libraries #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swannodette
force-pushed
the
bug/cljs-3332-firebase
branch
3 times, most recently
from
5ee42c7 to
1399dc1
Compare
Handle libraries that declare exports. Previously we only looked at top-level package.json. Expand this so that if top-level package.json declares exports, then we consider those package.json files as well. This leads to computing correct :provides with the exist logic which has worked suitably for some time. Add tests. Add some comments and docstrings to aid readability in the future.
swannodette
force-pushed
the
bug/cljs-3332-firebase
branch
from
f0122a3 to
c5a06c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
firebaseis a model case.