Skip to content

Conversation

bigcat88
Copy link
Member

@bigcat88 bigcat88 commented Sep 5, 2024

Changes proposed in this pull request:

  • Suppress all exceptions during nc.log

It's strange that I didn't do this before, without it we won't be able to use logging during exception handling.

@bigcat88 bigcat88 requested a review from kyteinsky September 5, 2024 11:39
@bigcat88 bigcat88 merged commit 1471e90 into main Sep 5, 2024
18 checks passed
@bigcat88 bigcat88 deleted the fix/supress-log-exceptions branch September 5, 2024 12:05
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.82%. Comparing base (3cde102) to head (241684c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #293   +/-   ##
=======================================
  Coverage   94.81%   94.82%           
=======================================
  Files          45       45           
  Lines        5304     5312    +8     
=======================================
+ Hits         5029     5037    +8     
  Misses        275      275           
Files with missing lines Coverage Δ
nc_py_api/_version.py 100.00% <100.00%> (ø)
nc_py_api/nextcloud.py 96.31% <100.00%> (+0.09%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants