Skip to content

AbstractSearch to support use of with by default #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lindyhopchris opened this issue Oct 18, 2016 · 1 comment
Closed

AbstractSearch to support use of with by default #24

lindyhopchris opened this issue Oct 18, 2016 · 1 comment
Milestone

Comments

@lindyhopchris
Copy link
Member

AbstractSearch should have a with method that receives the builder instance. By default, this should apply the contents of $this->with (a new property) if that property is not empty.

The with method should be invoked for both a standard search and a find many search.

This will encourage use of eager loading with searches, which is best practice because of the inefficiencies of not using eager loading when returning multiple JSON API resources at once.

@lindyhopchris lindyhopchris added this to the 0.6.0 milestone Oct 18, 2016
@lindyhopchris
Copy link
Member Author

This feature is now available on Adapter classes on the develop branch and will be released in v0.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant