Skip to content

Fix for methods in routes. #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 28, 2016
Merged

Fix for methods in routes. #5

merged 2 commits into from
Jan 28, 2016

Conversation

MCMatters
Copy link
Contributor

Fix for methods in relationship routes. Add support of options "only" and "except" in resource routes

@lindyhopchris
Copy link
Member

@MCMatters

Thanks for the pull request and good spot on the bug.

In terms of the "only" and "except" options, they're not strictly required. If you're using the JsonApiController then the controller will send 501 Not Implemented responses if you haven't defined the methods required for the route that is being dispatched.

I think that's correct because the JSON API spec defines that all those routes should be available, so from the client's perspective the route should exist. So a 501 response would be semantically correct.

Do you have a use for only and except that I'm not thinking of?

@MCMatters
Copy link
Contributor Author

Yes, you are right. I'm beginner in the Laravel and I thought that would be good to have this functional

@lindyhopchris
Copy link
Member

No problem. Can you update the pull request so that the options aren't in there? Then I'll be able to merge it.

@MCMatters
Copy link
Contributor Author

Yes, updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants