Use dates attribute from Eloquent model for hydrator by default #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstoone
suggested changes
Mar 1, 2017
src/Hydrator/EloquentHydrator.php
Outdated
| { | ||
| return in_array(Str::snake($resourceKey), $record->getDates(), true); | ||
| } | ||
| else |
There was a problem hiding this comment.
There is no need for the else here since you're returning early in the if statement itself. :)
protected function isDateAttribute($record, $resourceKey)
{
if (is_null($this->dates)) {
return in_array(Str::snake($resourceKey), $record->getDates(), true);
}
return in_array($resourceKey, $this->dates, true);
}
pedroluislopez
force-pushed
the
default-dates-attribute-hydrator
branch
from
bb05d05 to
ab0fde8
Compare
jstoone
suggested changes
Mar 1, 2017
src/Hydrator/EloquentHydrator.php
Outdated
| if(is_null($this->dates)) | ||
| { | ||
| return in_array(Str::snake($resourceKey), $record->getDates(), true); | ||
| } | ||
| return in_array($resourceKey, $this->dates, true); |
There was a problem hiding this comment.
Just one line-break before the return statement, then I'm done OCD'ing all over your code. 😅
pedroluislopez
force-pushed
the
default-dates-attribute-hydrator
branch
from
ab0fde8 to
b5a01d9
Compare
|
This is another great idea. I'll merge it into develop later today or tomorrow. |
|
This has been released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.