Formatter should be static

[grant]

I noticed the formatter lives within the CloudEvent object.

CloudEvent {
  spec:
   Spec1 {
     payload:
      { specversion: '1.0',
        id: '1234',
        time: '2020-05-28T20:46:18.970Z',
        source: '/some/source',
        type: 'example',
        datacontenttype: undefined,
        data: undefined,
        subject: undefined } },
  formatter: JSONFormatter {},
  extensions: [] }

This doesn't really make sense since we can have 1000 CloudEvent objects with the same formatter.

Maybe it should be a static class/set of methods.

[lance]

I was thinking actually of removing it entirely from the class, along with the format() function. Instead, expose a top level Formatter class or formatter() function that takes a CloudEvent and formats it as JSON by default. But of course that would be a breaking change and require a version bump. Making it static is a good first step.

[lholmquist]

Somewhat related is the toString method. All this is doing is a JSON.stringify, which could just as easily be done without this method.

Like the formatter, it would be a major version bump for removal though

[lholmquist]

@lance @grant if either of you haven't started to work on this, i could take a look at breaking the Formatter into its own function

[lance]

@lholmquist all yours

[grant]

☝️ All yours.

[lholmquist]

Probably going to hold off on this since it will be part of #226

should we close?