Skip to content

Browser Version of the module is still called cloudevents-sdk #286

Closed
@lholmquist

Description

@lholmquist

Describe the Bug
The name of the module changed in #260, but the webpack config was never updated, https://github.com/cloudevents/sdk-javascript/blob/master/webpack.config.js

Steps to Reproduce

  1. Create a Browser Application
  2. Bring in the cloudevents-sdk
  3. window[cloudevents-sdk] exists
    3a. Also, the cloudevents-sdk.js file exists in the built bundles folder

Expected Behavior
module name should be cloudevents

Additional context
Since the 3.0.0 release was just released, can we do this change without a major version bump? It is changing the name, so i think it has to be, but 3.x was just released, and the name was changed, so if we release a 3.0.2 soon, we might be able to get it in there without the major bump.

Metadata

Metadata

Assignees

No one assigned

    Labels

    module/browserModule capabilities in a browser environmenttype/bugSomething isn't workingversion/3.xIssues related to the 3.0 release of this library

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions