-
Notifications
You must be signed in to change notification settings - Fork 69
isCloudEvent Function #295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We do not have that in this module, although I can see it being useful. For a current project I am working on, we do this before trying to parse the event. https://github.com/boson-project/faas-js-runtime/blob/master/lib/event-handler.js#L32-L48 |
@lance What do you think about this logic? https://github.com/cloudevents/sdk-javascript/blob/master/src/event/cloudevent.ts
|
Hmm - I don't think that it makes sense for a static This would make more sense as a standalone function in
|
Yup, adding the method to the HTTP transport files instead of CloudEvent files makes sense. |
Fixes: #295 Signed-off-by: Lance Ball <[email protected]>
Describe the Bug
Is there an easy way to determine if a HTTP request is a CloudEvent or not?
It would be great if there was a
isCloudEvent
function or something similar. Maybe just documentation if we can re-use existing functions together to achieve this.Steps to Reproduce
Expected Behavior
The text was updated successfully, but these errors were encountered: