Skip to content

chore: Modify CI to also build backport branch(es) #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2020
Merged

chore: Modify CI to also build backport branch(es) #122

merged 1 commit into from
May 7, 2020

Conversation

helio-frota
Copy link
Contributor

Signed-off-by: Helio Frota [email protected]

@helio-frota helio-frota requested a review from lance May 5, 2020 12:21
@helio-frota helio-frota mentioned this pull request May 5, 2020
Closed
lance
lance approved these changes May 5, 2020
View reviewed changes
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@lance lance added chore/ci Changes to CI or the build version/1.x.backport Changes that should be backported to the 1.x release line status/stalled Issues that have not made progress recently labels May 5, 2020
@lance
Copy link
Member

lance commented May 6, 2020

Adding the label stalled here, as this may not be needed depending on the outcome of #85. We are currently planning a 2.0.0 release without plans for backporting anything to 1.0.0. Assuming a steady release cadence can be maintained, we may choose to support no prior versions once a new version is released. Stating here, for the record, I think that's a bad idea.

fabiojose
fabiojose approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@fabiojose fabiojose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lance
Copy link
Member

lance commented May 7, 2020

@helio-frota do you mind changing this to just handle the lts issue and removing the build of backport branches? (but keep master and pull request builds active). Thanks!

@lance lance merged commit c1fda94 into cloudevents:master May 7, 2020
@helio-frota helio-frota deleted the 121-modify-ci branch May 7, 2020 14:30
@helio-frota helio-frota self-assigned this May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance lance lance approved these changes

@fabiojose fabiojose fabiojose approved these changes

Assignees

@helio-frota helio-frota

Labels
chore/ci Changes to CI or the build status/stalled Issues that have not made progress recently version/1.x.backport Changes that should be backported to the 1.x release line
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@helio-frota @lance @fabiojose