Introduce Typescript #137
Closed
Introduce Typescript #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grant Timmerman <[email protected]>
Signed-off-by: Grant Timmerman <[email protected]>
Signed-off-by: Grant Timmerman <[email protected]>
Closed
cwallsfdc
reviewed
May 8, 2020
Signed-off-by: Grant Timmerman <[email protected]>
|
Closed in favor of #155. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces TypeScript to this repo. This is the first step to fix the top-voted issue, #9.
jstotsIt does require running
npm run watchto incrementally build ornpm run buildto build once. - For development, it's common to just runnpm run watchin one tab.npm run buildone time before publishing.We can't really see benefits right now, but features such as autocompletion, refactoring, automatic type annotation would come for free.