Skip to content

Simplify/TS Validation Files #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 23, 2020
Merged

Simplify/TS Validation Files #265

merged 2 commits into from
Jul 23, 2020

Conversation

grant
Copy link
Member

@grant grant commented Jul 23, 2020

This PR simplifies the validation logic by removing the folder and just keeping the logic in a validation.ts file.

Mainly reduces code and improves readability while keeping same functionality.

@grant grant requested a review from lance July 23, 2020 22:22
@grant grant self-assigned this Jul 23, 2020
lance
lance reviewed Jul 23, 2020
View reviewed changes
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just clarifying... it does not appear that this actually changes the logic - simply that you've combined the is.ts and validation_error.ts into a single file. Correct?

grant
grant commented Jul 23, 2020
View reviewed changes
Copy link
Member Author

@grant grant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, no logic/functional changes.

Just the import/exports. I should probably use a better PR title/description.

@lance lance changed the title Simplify/TS Validation Logic Simplify/TS Validation Files Jul 23, 2020
lance
lance approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grant grant merged commit 4b54b27 into cloudevents:master Jul 23, 2020
@grant grant deleted the grant_validation branch July 23, 2020 23:09
@lance lance mentioned this pull request Jul 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance lance lance approved these changes

Assignees

@grant grant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grant @lance