lib: change Receiver#accept() to be static Receiver.accept #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that I did not add a third `Protocol` parameter to `Receiver.accept` since that would not currently be used. It's non-breaking to add a third parameter in the future once additional protocols are supported. Fixes: cloudevents#266 Fixes: cloudevents#261 BREAKING CHANGE Signed-off-by: Lance Ball <[email protected]>
lance
requested review from
a team,
danbev,
grant,
helio-frota and
lholmquist
and removed request for
a team
lance
added
module/lib
grant
approved these changes
Jul 24, 2020
Closed
lholmquist
approved these changes
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that I did not add a third
Protocolparameter toReceiver.acceptsincethat would not currently be used. It's non-breaking to add a third parameter
in the future once additional protocols are supported.
Fixes: #266
Fixes: #261
BREAKING CHANGE