fix: allow TypedArray for binary data
#494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we only considered `Uint32Array` binary data. This was an oversight. This fixes that issue. Fixes: cloudevents#491 Signed-off-by: Lance Ball <[email protected]>
grant
suggested changes
Jun 14, 2022
Signed-off-by: Lance Ball <[email protected]>
|
Closing and reopening to pick up changes to package.json in CI and hopefully resolve CI errors. |
|
Updated with your suggestions @grant and CI is passing. PTAL |
lance
changed the title
Uint16|8Array for binary dataTypedArray for binary data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we only considered
Uint32Arraybinary data. This was an oversight. This fixes that issue.Fixes: #491
Signed-off-by: Lance Ball [email protected]