Change unused dependency to dev_dependency #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tottoto <[email protected]>
|
Do we really need |
slinkydeveloper
added
documentation
|
I think we need The actix-web's official document for testing uses |
|
Ok then I'm fine with it |
|
Thanks for your contribution! |
slinkydeveloper
added
cloudevents-sdk-actix-web
and removed
documentation
tottoto
deleted the
feature/change_unused_dependency_to_dev_dependency
branch
|
Related issue(actix/actix-web#1669). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actix_rt is only used in tests.
Signed-off-by: tottoto [email protected]