Use bindgen to automatically generate boring-sys #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedisct1
changed the title
|
Fixes #10 |
|
This is awesome, thanks! Can we keep |
inikulin
reviewed
Feb 12, 2021
inikulin
reviewed
Feb 12, 2021
inikulin
reviewed
Feb 12, 2021
inikulin
reviewed
Feb 12, 2021
|
The Windows CI issue is due to KyleMayes/clang-sys#121 Should be good now! |
inikulin
approved these changes
Feb 12, 2021
This ensures that all the Rust functions, types and constants always match the actual BoringSSL definitions. It also removes quite a lot of manually maintained code, as well as the need for systest. The value for `SslOptions::ALL`, for example, was wrong. On current BoringSSL versions, this is a no-op, and is set to `0`. Clearing it does nothing. So, the `clear_ctx_options` test, that passed by accident, was adjusted to use a different option. The `libc` crate is not required, as we only use it for types that are already defined in the standard library. It was removed from `boring-sys`. The same can be done to other crates later.
|
wbl
approved these changes
Feb 16, 2021
shahn
pushed a commit
to shahn/boring
that referenced
this pull request
Oct 28, 2023
shahn
pushed a commit
to shahn/boring
that referenced
this pull request
Oct 28, 2023
Put 1.70 in there (for instance if you want to pin against OnceLock stabilizing) and it will actually test 1.7 as it appears github auto converts this to a float? Putting in quotes seems to do the right thing here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that all the Rust functions, types and constants always match the actual BoringSSL definitions.
It also removes quite a lot of manually maintained code, as well as the need for
systest.The value for
SslOptions::ALL, for example, was wrong. On current BoringSSL versions, this is a no-op, and is set to0.Clearing it does nothing. So, the
clear_ctx_optionstest, that passed by accident, was adjusted to use a different option.The
libccrate is not required, as we only use it for types that are already defined in the standard library. It was removed fromboring-sys. The same can be done to other crates later.