Add temporary_enable_v2 flag to cc-worker config #488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
jochenehret
force-pushed
the
temp-v2-flag-for-cc-worker
branch
from
4c5ad61 to
52c4381
Compare
* avoids redundant configuration
jochenehret
force-pushed
the
temp-v2-flag-for-cc-worker
branch
from
52c4381 to
73cb8f8
Compare
johha
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
Add
temporary_enable_v2config flag to cc-worker configuration. Required for service broker client fix: Service broker client: Set 'X-Api-Info-Location' according to 'temporary_enable_v2' cloud_controller_ng#4058An explanation of the use cases your change solves
Part of v2 deprecation story: [RFC] CF API v2 End of Life community#941
Links to any other associated PRs
Service broker client: Set 'X-Api-Info-Location' according to 'temporary_enable_v2' cloud_controller_ng#4058
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
developbranchI have run CF Acceptance Tests on bosh lite
-> ran tests on new "gyro" env: https://concourse.app-runtime-interfaces.ci.cloudfoundry.org/teams/capi-team/pipelines/capi/jobs/gyro-exp-tests/builds/5
Test suite is basically green with this PR. The 4 failing tests must be fixed in CATs.