Show warning message if setting deployment configured feature flag via API #4532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yment - Added the code to override default feature flags upon initialization of new deployment. - TNZ-48301
hsinn0
force-pushed
the
setting_deployment-configured_feature_flag_via_api
branch
from
a9bb0f5 to
e149433
Compare
- Changed the error message for invalid flag names and values to be more specific. - Changed to do stronger test assertions for error message validations.
hsinn0
force-pushed
the
setting_deployment-configured_feature_flag_via_api
branch
from
e149433 to
dc66b55
Compare
hsinn0
force-pushed
the
setting_deployment-configured_feature_flag_via_api
branch
from
dc66b55 to
630ad07
Compare
…figured feature flags - Added a warning message to present when a deployment-configured feature flag is updated via API. - TNZ-48303
hsinn0
force-pushed
the
setting_deployment-configured_feature_flag_via_api
branch
from
630ad07 to
cbccb6c
Compare
Gerg
changed the base branch from
main
to
dependabot/bundler/newrelic_rpm-9.21.0
Gerg
changed the base branch from
dependabot/bundler/newrelic_rpm-9.21.0
to
main
|
Cloud Controller is configured to only support squash merges, which makes this PR annoying to rebase after I merged #4523. I went ahead and cherry-picked the commit onto main, if it's helpful: https://github.com/cloudfoundry/cloud_controller_ng/commits/hsinn0-setting_deployment-configured_feature_flag_via_api/ |
|
Opened a new PR here: #4540 |
|
Merged in #4540 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
Implementing feature - Platform Engineer sees a warning when specifying deployment-configured feature flags
An explanation of the use cases your change solves
See the above.
Links to any other associated PRs
Depends on feat: Platform Engineer can configure CF feature flags via bosh deplo… #4523.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests