Skip to content

Web socket communications via route services #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Dariquest
Copy link

Documentation for the PR cloudfoundry/routing-release#474

@anita-flegg
Copy link
Contributor

@Dariquest , I'm not sure this is the right branch -- the latest would be better.
Also, do you want this change in any of the TPCF branches?

@Dariquest
Copy link
Author

Dariquest commented May 22, 2025

@Dariquest , I'm not sure this is the right branch -- the latest would be better. Also, do you want this change in any of the TPCF branches?

Hi Anita @anita-flegg, which branch do you propose? The master seems right to me.
Which branches do you mean additionally (TPCF)? Could you provide links, please?

@anita-flegg
Copy link
Contributor

You're right, @Dariquest, master is the correct branch for this.
I will find out if there are additional places that will need this change.
Thanks! :)

@ameowlia
Copy link
Member

👋 Hi @Dariquest, Thank you so much for creating a docs PR!!!! 🥰

  1. This work should be included in routing-release 0.339.0, but it has not made it through the pipeline yet (because the pipelines are paused because of 🔥 ). @anita-flegg - We should not merge this PR until it is officially in that release.

  2. This wording provided should be for the OSS docs only.

  3. We do not need anything for TPCF docs. We are not going to expose this property in TPCF. We will document this change in TPCF with a release note that marks this as a bug fix.

@anita-flegg
Copy link
Contributor

@ameowlia -- thanks very much for your help! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants