add reset brightness #17
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pikaju
reviewed
Sep 11, 2019
| break; | ||
| case "keepOn": | ||
| Boolean on = call.argument("on"); | ||
| Boolean on = call.argument("on"); |
There was a problem hiding this comment.
That space probably shouldn't be there.
| static Future setBrightness(double brightness) =>_channel.invokeMethod('setBrightness',{"brightness" : brightness}); | ||
| static Future<bool> get isKeptOn async => (await _channel.invokeMethod('isKeptOn')) as bool; | ||
| static Future keepOn(bool on) => _channel.invokeMethod('keepOn', {"on" : on}); | ||
| static Future resetBrightness() => _channel.invokeMethod('resetBrightness'); |
There was a problem hiding this comment.
I wonder if a different name would be appropriate. The brightness isn't really "reset", it's more like, the brightness override is removed?
There was a problem hiding this comment.
Could you suggest me an appropriate name? @pikaju
karansingla-dev
commented
Oct 1, 2019
| static Future setBrightness(double brightness) =>_channel.invokeMethod('setBrightness',{"brightness" : brightness}); | ||
| static Future<bool> get isKeptOn async => (await _channel.invokeMethod('isKeptOn')) as bool; | ||
| static Future keepOn(bool on) => _channel.invokeMethod('keepOn', {"on" : on}); | ||
| static Future resetBrightness() => _channel.invokeMethod('resetBrightness'); |
There was a problem hiding this comment.
Could you suggest me an appropriate name? @pikaju
This reverts commit e3b2dd5
|
@singlakaran isn't it missing the iOS implementation for resetBrightness ? I've got |
|
@benoitskipr yes i know. i dont have mac |
|
@benoitskipr please use this pakage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reset brightness
@ened @clovisnicolas @matejm @IKStreamIvo please review and merge