Simplify usage by supporting new default loop #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
requested changes
Aug 12, 2021
There was a problem hiding this comment.
@PaulRotmann Thanks for looking into this, added some remarks below 👍
|
|
||
| try { | ||
| $ip = Block\await($promise, $loop); | ||
| $ip = Block\await($promise); |
There was a problem hiding this comment.
Not supported by underlying await() function
| ```php | ||
| $loop = React\EventLoop\Factory::create(); | ||
| $factory = new Factory($loop); | ||
| $factory = new Factory(); |
There was a problem hiding this comment.
LGTM, but could use some additional docs?
| ); | ||
|
|
||
| $ips = Block\awaitAll($promises, $loop); | ||
| $ips = Block\awaitAll($promises); |
|
|
||
| $loop = React\EventLoop\Factory::create(); | ||
| $factory = new Clue\React\Mdns\Factory($loop); | ||
| $factory = new Clue\React\Mdns\Factory(); |
There was a problem hiding this comment.
LGTM, but example still references a leftover $loop?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset simplifies usage by supporting the new default loop.
Builds on top of reactphp/event-loop#226, reactphp/event-loop#229, reactphp/event-loop#231, reactphp/event-loop#232.