Update ubuntu for arm compiler crashes #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: clux <[email protected]>
|
Would love to see a fix here so we can use 1.85 and 2024 edition 🙏 |
Signed-off-by: clux <[email protected]>
also remove a (now-default) removed flag. Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
|
it's been a weird one. it's failing only on arm and the error is literally a core dump or compiler error in the middle of compilation. have gotten it mostly working locally by sidestepping it with an ubuntu upgrade, but curl is acting up. i might actually kill curl for now (also noted in #96 and no one has said anything, and i don't think it's heavily relied on). hopefully will get a release through with/without curl. |
also add nicer separation of local dev and ci entrypoints Signed-off-by: clux <[email protected]>
|
Finally, green, merging as is. curl be damned. |
|
thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
red CI on arm with compiler errors and core dumps for 3 weeks. resolved by:
The only big change here should curl removal, which at this point SHOULD be reasonable. I doubt many people use curl crate over hyper at this point, and if you are, you probably shouldn't. Anyway, reach out on #96 if you disagree.