Implement support for task statement in HTML and MD #1086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW, we are already using Markdown for task statements. We using |
|
Example statement in Markdown, with PDF output: |
|
Let's try to merge #1067 first |
|
Now that #1067 is merged, maybe this can be considered 😃 |
Codecov Report
@@ Coverage Diff @@
## master #1086 +/- ##
==========================================
- Coverage 61.99% 42.09% -19.9%
==========================================
Files 228 230 +2
Lines 16460 16711 +251
==========================================
- Hits 10204 7035 -3169
- Misses 6256 9676 +3420
Continue to review full report at Codecov.
|
The AWS html template generates 'wrong' field names since now we have both the language and the file type, and the template uses only the language. We should change the template but for now I just extract the language key from the full (lang, type) key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested adding (from AWS and from CLI) and removing (from AWS), and tested the rendering.
If you like this change, I think the only change needed is to write the DB updater (and "vendorize" the new JS dependencies, I didn't do it here because I didn't want to push big files).
This change is