Skip to content

Add signals from NSSP secondary source #2073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
5 tasks done
minhkhul opened this issue Nov 6, 2024 · 2 comments · Fixed by #2074 or cmu-delphi/delphi-epidata#1558
Closed
5 tasks done

Add signals from NSSP secondary source #2073

minhkhul opened this issue Nov 6, 2024 · 2 comments · Fixed by #2074 or cmu-delphi/delphi-epidata#1558
Assignees
Labels
API addition New signals

Comments

@minhkhul
Copy link
Contributor

minhkhul commented Nov 6, 2024

Data details

Basically we're adding 4 signals from this secondary nssp source dataset. They report essentially the same data as the main dataset, but only available at state level and above. However, it appears this secondary source updates quicker than the main source recently.

Additional context
Context: https://delphi-org.slack.com/archives/C0130CSQRN3/p1730476295781409

TODO:

  • Confirm names with Roni
  • Test runs on staging
  • Release
  • Update public facing docs
  • Talk to Carlyn about signal sheets/app.
@minhkhul minhkhul added the API addition New signals label Nov 6, 2024
@minhkhul minhkhul self-assigned this Nov 6, 2024
@minhkhul minhkhul linked a pull request Nov 6, 2024 that will close this issue
2 tasks
@minhkhul minhkhul mentioned this issue Nov 6, 2024
2 tasks
@minhkhul minhkhul linked a pull request Nov 17, 2024 that will close this issue
4 tasks
@minhkhul minhkhul reopened this Nov 19, 2024
@minhkhul
Copy link
Contributor Author

seg faults on staging when testing. Seems deeper problem with python versioning.

@minhkhul
Copy link
Contributor Author

Things are up and running on staging again. Removed create_backup_csv due to unrelated issue. Then ran the indicator with secondary signals code + acquisition to staging db for testing. Result looks reasonable:
Indicator run on staging: https://cronicle-prod-01.delphi.cmu.edu/#JobDetails?id=jm3t9mtqzvq
Acquisition run on staging: https://cronicle-prod-01.delphi.cmu.edu/#JobDetails?id=jm3t9qfpfvr
Some querying on staging db:

mysql> SELECT `signal`, issue, geo_type, COUNT(*) FROM epimetric_full_v WHERE source 
= 'nssp' AND `signal` LIKE '%2023rvr' GROUP BY `signal`, issue, geo_type;
+---------------------------------+--------+----------+----------+
| signal                          | issue  | geo_type | COUNT(*) |
+---------------------------------+--------+----------+----------+
| pct_ed_visits_combined_2023rvr  | 202447 | state    |     5124 |
| pct_ed_visits_combined_2023rvr  | 202447 | hhs      |     1070 |
| pct_ed_visits_combined_2023rvr  | 202447 | nation   |      107 |
| pct_ed_visits_covid_2023rvr     | 202447 | state    |     5124 |
| pct_ed_visits_covid_2023rvr     | 202447 | hhs      |     1070 |
| pct_ed_visits_covid_2023rvr     | 202447 | nation   |      107 |
| pct_ed_visits_influenza_2023rvr | 202447 | state    |     5124 |
| pct_ed_visits_influenza_2023rvr | 202447 | hhs      |     1070 |
| pct_ed_visits_influenza_2023rvr | 202447 | nation   |      107 |
| pct_ed_visits_rsv_2023rvr       | 202447 | state    |     5124 |
| pct_ed_visits_rsv_2023rvr       | 202447 | hhs      |     1070 |
| pct_ed_visits_rsv_2023rvr       | 202447 | nation   |      107 |
+---------------------------------+--------+----------+----------+
12 rows in set (0.04 sec)

Looks reasonable. Can release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API addition New signals
Projects
None yet
2 participants