-
Notifications
You must be signed in to change notification settings - Fork 16
Geo type mapping #1159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geo type mapping #1159
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 in broad strokes, looping in Dmitry to check the details
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have some comments about things that could reuse existing functions and spotted a possible bug with using an internal cache variable. Otherwise looks good 👍 .
Found a refactoring suggestion for you using some cool Pandas tricks and a few minor nits. After that we'll be golden! |
|
Description
add Geo type Mapper function in GeoMapper class: Return all contained/child regions
Changelog
Fixes