Skip to content

Geo type mapping #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 6, 2021
Merged

Geo type mapping #1159

merged 12 commits into from
Aug 6, 2021

Conversation

zhuoran-Cheng16
Copy link
Contributor

Description

add Geo type Mapper function in GeoMapper class: Return all contained/child regions

Changelog

  • add get_geo_mapper function
  • add unit test of get_geo_mapper

Fixes

@zhuoran-Cheng16 zhuoran-Cheng16 requested a review from krivard July 30, 2021 18:22
@krivard krivard requested a review from dshemetov August 2, 2021 18:26
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 in broad strokes, looping in Dmitry to check the details

Copy link
Contributor

@dshemetov dshemetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have some comments about things that could reuse existing functions and spotted a possible bug with using an internal cache variable. Otherwise looks good 👍 .

@dshemetov
Copy link
Contributor

Found a refactoring suggestion for you using some cool Pandas tricks and a few minor nits. After that we'll be golden!

@dshemetov
Copy link
Contributor

:shipit: :shipit: :shipit:

@krivard krivard merged commit f75b651 into main Aug 6, 2021
@krivard krivard deleted the geo_type_mapping branch August 6, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geo Mapper: Return all contained/child regions
3 participants