Alternate: Add NCHS mortality geo aggregation at the HHS and nation levels #1258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on #1243. Original PR text from @alexcoda follows:
Add NCHS mortality geo aggregation at the HHS and nation levels.
Note that because one of the columns being aggregated is a percentage, we're doing a weighted sum with the geomapper
Also there are some pylint disables for too many branches, this is because of the slight difference in logic for handling the percentage vs. count variables. This could be refactored later for the entire run.py function, but is not in scope for this change.
Fixes