Skip to content

DSEW-CPR: Extend files to be processed for interpolation #1578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2022

Conversation

krivard
Copy link
Contributor

@krivard krivard commented Apr 14, 2022

Description

when filtering the file listing for what to process, extend the final list by (INTERP_LENGTH-1) days backward from each desired file, so that we have something to interpolate with.

Linting errors are extant in #1555

Changelog

Itemize code/test/documentation changes and files added/removed.

  • constants: add INTERP_LENGTH
  • pull: add extend_listing_for_interp
  • test: check single range, ranges that don't overlap, and ranges that do overlap.

Fixes

@krivard krivard requested a review from dshemetov April 14, 2022 14:58
Copy link
Contributor

@dshemetov dshemetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thank you!

@dshemetov dshemetov merged commit 917baef into ds/dsew-interpolation Apr 14, 2022
@krivard krivard deleted the krivard/dsew-interp-extend-listing branch April 18, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants