-
Notifications
You must be signed in to change notification settings - Fork 16
Final changelog/codebook changes #1648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
No longer needed. UMD QSFs have been modified so that question names are unique per wave. To accomplish this, some items that had display logic set to FALSE (not shown) were instead moved to the trash.
68f5e13
to
aeb22f9
Compare
Have the codebooks produced by this already been reviewed by others, e.g. by Zheng and Adrianne? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks fine, just nitpicks/questions
@@ -46,7 +48,7 @@ WAVE_COMPARE_MAP <- list( | |||
|
|||
DIFF_COLS <- c( | |||
"question", | |||
"matrix_subquestion", | |||
"subquestion", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our microdata documentation currently describes the column as
* `matrix_subquestion`: Subquestion text for a matrix item.
What should that say for the updated column?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CMU documentation still says matrix_subquestion
, so the description is still valid. For UMD, the subquestion
field is for both matrix and dropdown subquestion/component text.
Wichada has reviewed the codebooks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I understand your first sentence. Are you saying CMU microdata files will still contain a matrix_subquestion
column?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CMU codebook files still currently contain a matrix_subquestion
column, yes. CMU doesn't have dropdowns that have extra component text, so I didn't regenerate the codebook files. Should I?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't plan to regenerate the CMU codebooks again, that's fine, we can leave the documentation as-is. I was just confused because I thought this meant the column name was changing in our files.
You may want to make sure Zheng changes the UMD microdata documentation, since a lot of the parts were copied from our documentation.
Co-authored-by: Alex Reinhart <[email protected]>
Co-authored-by: Alex Reinhart <[email protected]>
@krivard this is ready to merge. |
Description
NA
for clarity.profile
andlikert
renaming (e.g.B12_profile
) now that the underlying items have been removed in the QSF files.Changelog
qsf-tools/generate-changelog.R