Skip to content

Final changelog/codebook changes #1648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Oct 3, 2022
Merged

Final changelog/codebook changes #1648

merged 18 commits into from
Oct 3, 2022

Conversation

nmdefries
Copy link
Contributor

@nmdefries nmdefries commented Jun 23, 2022

Description

  • Replace "differ by subq" language with NA for clarity.
  • Modify changelog/codebook field names for clarity.
  • Handle dropdown items like matrix items.
  • Remove profile and likert renaming (e.g. B12_profile) now that the underlying items have been removed in the QSF files.
  • Make functions that get wave number from filenames support "version" format too ("v10" vs "wave10").
  • Save modified translation files to new directory.
  • Update codebook description files.

Changelog

  • qsf-tools/generate-changelog.R

@nmdefries nmdefries force-pushed the ndefries/final-qsf-fixes branch from 68f5e13 to aeb22f9 Compare August 11, 2022 17:31
@nmdefries nmdefries marked this pull request as ready for review September 30, 2022 14:40
@capnrefsmmat
Copy link
Contributor

Have the codebooks produced by this already been reviewed by others, e.g. by Zheng and Adrianne?

Copy link
Contributor

@capnrefsmmat capnrefsmmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks fine, just nitpicks/questions

@@ -46,7 +48,7 @@ WAVE_COMPARE_MAP <- list(

DIFF_COLS <- c(
"question",
"matrix_subquestion",
"subquestion",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our microdata documentation currently describes the column as

* `matrix_subquestion`: Subquestion text for a matrix item.

What should that say for the updated column?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMU documentation still says matrix_subquestion, so the description is still valid. For UMD, the subquestion field is for both matrix and dropdown subquestion/component text.

Wichada has reviewed the codebooks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand your first sentence. Are you saying CMU microdata files will still contain a matrix_subquestion column?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMU codebook files still currently contain a matrix_subquestion column, yes. CMU doesn't have dropdowns that have extra component text, so I didn't regenerate the codebook files. Should I?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't plan to regenerate the CMU codebooks again, that's fine, we can leave the documentation as-is. I was just confused because I thought this meant the column name was changing in our files.

You may want to make sure Zheng changes the UMD microdata documentation, since a lot of the parts were copied from our documentation.

nmdefries and others added 2 commits October 3, 2022 10:15
Co-authored-by: Alex Reinhart <[email protected]>
Co-authored-by: Alex Reinhart <[email protected]>
@nmdefries
Copy link
Contributor Author

@krivard this is ready to merge.

@krivard krivard merged commit cf4c7b7 into main Oct 3, 2022
@krivard krivard deleted the ndefries/final-qsf-fixes branch October 3, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants