Skip to content

[CTIS] Add a few missing indicators and wave-specific handling for multi-selects #1695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 29, 2022

Conversation

nmdefries
Copy link
Contributor

@nmdefries nmdefries commented Sep 14, 2022

Description

Add a few missing indicators that FB docs are expecting. Fix a couple spelling/naming issues. Add wave-specific handling, e.g., for some multi-select responses that didn't exist the entire time the question was fielded. This only impacts contingency signals.

Changelog

  • contingency_indicators.R
  • contingency_variables.R

@nmdefries nmdefries changed the title [CTIS] Add a few missing indicators [CTIS] Add a few missing indicators and wave-specific handling for multi-selects Sep 21, 2022
@nmdefries nmdefries marked this pull request as ready for review September 21, 2022 19:47
Copy link
Contributor

@capnrefsmmat capnrefsmmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think

@nmdefries
Copy link
Contributor Author

@krivard This is ready to merge.

@krivard krivard merged commit 08d2c2f into main Sep 29, 2022
@krivard krivard deleted the ndefries/final-contingency-fixes branch September 29, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants