Clarify API reference data error messages; authenticate API reference data requests #1874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets the `meta` and `signal` calls share the same authentication init. We also don't need to do a second `read_params` in `get_geo_signal_combos`; instead pass the API key as an arg.
nmdefries
changed the title
|
Need to fix tests! |
krivard
reviewed
Jul 21, 2023
Co-authored-by: Katie Mazaitis <[email protected]>
minhkhul
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Address this comment.
google-symptomsvalidation was failing with an ambiguous error message,Error fetching data from 2023-06-20 to 2023-07-17 for data source: google-symptoms....To enable better debugging in the future, change the wording to be more specific and add a check for a
NoneAPI result. Also authenticate COVIDcast requests in a more general way, adding the API key to theParametersobject.Changelog
delphi_utils/validator/dynamic.pydelphi_utils/validator/datafetcher.py