Skip to content

fix jenkins builds #1988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2024
Merged

fix jenkins builds #1988

merged 2 commits into from
Jul 10, 2024

Conversation

melange396
Copy link
Contributor

the jenkins builds broke, and the logs led me to believe the newly released scs version (a dependency of cvxpy) might be to blame. then i found a VERY recent scs gh issue that looks similar to what we are seeing.

i tried to test this fix in a few ways but couldnt get them to work easily -- i think they'd need deeper changes to our jenkins config, which probbly isnt worth it. praps we can merge this into main and see if it does the trick?

@melange396 melange396 added bug Something isn't working release-blocking If this is not fixed by feature freeze time, kick this feature out of the release. devops labels Jul 10, 2024
Copy link
Contributor

@korlaxxalrok korlaxxalrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :shipit:

@melange396
Copy link
Contributor Author

🤞

@melange396 melange396 merged commit 5d4fdbd into main Jul 10, 2024
17 checks passed
@melange396 melange396 deleted the jenkins_scs_fix branch July 10, 2024 13:45
@melange396 melange396 changed the title attempt to fix jenkins builds fix jenkins builds Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working devops release-blocking If this is not fixed by feature freeze time, kick this feature out of the release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants