Skip to content

Fix new date for google symptoms #2015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 12, 2024
Merged

Conversation

aysim319
Copy link
Contributor

@aysim319 aysim319 commented Aug 9, 2024

Description

When validating the patch, there was an issue where the lag would be taken for custom runs where it would not be applicable
and some clean ups

Changelog

Itemize code/test/documentation changes and files added/removed.

  • added test data that would properly check the signal date ranges
  • conditionally adding the extra lag
  • minor cleanup mentioned in PR for 1996

Associated Issue(s)

  • Addresses #(1996) bug

@aysim319 aysim319 requested a review from nmdefries August 9, 2024 14:54
Copy link
Contributor

@nmdefries nmdefries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question/issue in a test

@nmdefries nmdefries merged commit c7bf03e into main Aug 12, 2024
16 checks passed
@nmdefries nmdefries deleted the fix_new_date_for_google_symptoms branch August 12, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants