Skip to content

[flask]: add new parameter version: signal,time,geo #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 8, 2021

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Apr 7, 2021

closes #389

in a backward compatibility way

supports alternative way to specify the three dimensions, see google doc

e.g., /covidcast/?signal=src1:sig1&time=day:20201202&geo=state:*

@sgratzl sgratzl self-assigned this Apr 7, 2021
@sgratzl sgratzl requested a review from krivard April 7, 2021 17:35
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor questions to resolve

@sgratzl sgratzl changed the title add new parameter version: signal,time,geo [flask]: add new parameter version: signal,time,geo Apr 8, 2021
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sgratzl sgratzl merged commit 0163043 into sgratzl/flaskx Apr 8, 2021
@sgratzl sgratzl deleted the sgratzl/flask_covidcast_params branch April 8, 2021 16:24
@sgratzl sgratzl mentioned this pull request May 14, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants