Fix Flask Jinja dependency #891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the v4 equivalent of #877 ? |
|
Oh, yep, looks like it 👍 Maybe we could merge |
|
There are major conflicts, largely due to the "delete from CSV" work we needed for Quidel. This PR will add another, but it's minor, so I'm not opposed |
|
Ok, good deal. It is a necessity for now as the test env is failing to start because of the jinja deprecation 💥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites:
devbranchdevSummary
Jinja is a dependency of Flask. In Jinga 3.1.0,
escapeis deprecated and should be imported from MarkupSafe. We can pinjinja<3.1.0to work around this for now.Probably the better fix will be to update Flask, but since we are already pinning it to an older version it seems likely that we can't do this easily.