Skip to content

renamed v4 db objects: load, latest, and history tables, and their id columns #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 29, 2022

Conversation

melange396
Copy link
Collaborator

@melange396 melange396 commented Aug 29, 2022

src/ddl/migrations/v4_renaming.sql - contains the SQL to do the renaming of a live v4 system

source code changes were done by these 4 shell commands:

  find ./src ./tests ./integrations -type f -exec sed -i 's/signal_history/epimetric_full/g' {} \;
  find ./src ./tests ./integrations -type f -exec sed -i 's/signal_latest/epimetric_latest/g' {} \;
  find ./src ./tests ./integrations -type f -exec sed -i 's/signal_load/epimetric_load/g' {} \;
  find ./src ./tests ./integrations -type f -exec sed -i 's/signal_data_id/epimetric_id/g' {} \;

all tests pass on the codebase as it stands in this commit;
they also pass on a delphi_web_epidata docker image that was created before this commit and then had the migration file changes applied to it.

… columns

src/ddl/migrations/v4_renaming.sql - contains the SQL to do the renaming of a live v4 system

source code changes were done by these 4 shell commands:
  find ./src ./tests ./integrations -type f -exec sed -i 's/signal_history/epimetric_full/g' {} \;
  find ./src ./tests ./integrations -type f -exec sed -i 's/signal_latest/epimetric_latest/g' {} \;
  find ./src ./tests ./integrations -type f -exec sed -i 's/signal_load/epimetric_load/g' {} \;
  find ./src ./tests ./integrations -type f -exec sed -i 's/signal_data_id/epimetric_id/g' {} \;

all tests pass on the codebase as it stands in this commit;
they also pass on a `delphi_web_epidata` docker image that was created before this commit and then had the migration file changes applied to it.
@melange396 melange396 added the v4 Big covidcast schema redesign label Aug 29, 2022
@melange396
Copy link
Collaborator Author

note: the find commands were designed to avoid the .git/ directory

Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👍

Co-authored-by: Katie Mazaitis <[email protected]>
@melange396 melange396 merged commit 1fe5b9c into v4-schema-revisions-release-prep Aug 29, 2022
@melange396 melange396 deleted the db_obj_renaming branch August 29, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v4 Big covidcast schema redesign
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants