Skip to content

update base url to api.delphi.cmu.edu #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2023
Merged

Conversation

melange396
Copy link
Contributor

follow-up to #103

approvals are very welcome, but this should not be merged until we have a new cert installed for api.delphi.cmu.edu. (PR is in draft status to prevent accidental merging.)

dshemetov
dshemetov previously approved these changes May 17, 2023
@dshemetov
Copy link
Contributor

dshemetov commented May 17, 2023

@melange396 CI is giving this error:

SSL peer certificate or SSH remote key was not OK: [api.delphi.cmu.edu] SSL: no alternative certificate subject name matches target host name 'api.delphi.cmu.edu'

Is this something that needs to get updated server-side?

@melange396
Copy link
Contributor Author

Is this something that needs to get updated server-side?

yes. when its done, those errors should no longer appear and thus the tests should pass... and then the PR is safe to merge

@melange396 melange396 marked this pull request as ready for review May 18, 2023 12:53
@melange396 melange396 requested a review from dajmcdon as a code owner May 18, 2023 12:53
@melange396
Copy link
Contributor Author

cert is in place now. i reran CI and those errors have ceased.

@dshemetov dshemetov enabled auto-merge May 18, 2023 17:06
@dshemetov dshemetov disabled auto-merge May 18, 2023 17:06
@dshemetov dshemetov merged commit 00f836c into dev May 18, 2023
@dshemetov dshemetov deleted the replace_proxy_references branch May 18, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants