refactor(epidatacall): remove fetch_csv and use testthat mocking
#115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use testthat::with_mocked_bindings for test mocking * delete fetch_csv
brookslogan
approved these changes
May 26, 2023
Co-authored-by: brookslogan <[email protected]>
dsweber2
reviewed
May 30, 2023
tests/testthat/test-epidatacall.R
Outdated
| csv_out <- epidata_call %>% fetch_csv() | ||
| expect_identical(tbl_out, csv_out) | ||
| # This test compares the output of a tibble using fetch and fetch_tbl. | ||
| with_mocked_bindings( |
There was a problem hiding this comment.
When I run this locally with no internet connection, its hanging. This makes me think content isn't being mocked and the test is just calling the server.
There was a problem hiding this comment.
thanks for pointing this out. the problem was that I was mocking httr::content, which parse the response, but i didnt mock epidatr::request_impl, which was still making a request (even though the request wasn't being used).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #110 and addresses this comment.