ci(ci)+fix(api limit): refactor to use latest actions and workaround api key warning #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* detect and use string manipulation to ignore the first row warning * alphabetize Imports in DESCRIPTION * add stringr dependency temporarily * \dontrun all the endpoint examples (should've done this before) * temporarily comment out a test * remove `delphi` endpoint call in main vignette
dshemetov
changed the title
brookslogan
requested changes
Jun 8, 2023
brookslogan
approved these changes
Jun 8, 2023
There was a problem hiding this comment.
Didn't look too much at CI, just trusting it's doing something sane. Warnings have been replaced by errors + messages about how to fix, more closely matching Phase 2 rollout goals. [As dshemetov noted, we should soon use an API key in CI and back out these dontrun changes.]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.