Extreme requests

[dsweber2]

Adds two parameters to several functions:

• timeout_seconds gives the maximum time before a connection will time out. Default is 30 seconds, which matches the value returned in the call below (can't find documentation for httr's default, since it clearly isn't using libcurl's). Originally motivated by

  chng_outpatient <- epidatr::covidcast(
    data_source = "chng", signals = "smoothed_adj_outpatient_covid",
    geo_type = "state",
    time_type = "day",
    time_values = "*",
    geo_values = "*",
    issues = epirange("2020-11-16","2021-03-16")
  ) %>% fetch()
  

  which returns a timeout message, trying 3 times. A working version in this branch is

  chng_outpatient <- epidatr::covidcast(
    data_source = "chng", signals = "smoothed_adj_outpatient_covid",
    geo_type = "state",
    time_type = "day",
    time_values = "*",
    geo_values = "*",
    issues = epirange("2020-11-16","2021-03-16")
  ) %>% fetch(timeout_seconds = 2.5 * 60)
  

  I'm not sure there's a nice way to add a unit test for something like this however. Perhaps httptest has something.
• return_empty, which handles the case of no returned results whatsoever. Defaults to FALSE, which is the current value. Even if its true it throws a warning. We may want to consider making TRUE the default. I debated adding headers to empty columns, but it ended up being more awkward to use on the other end.
  Should be relatively easy to add tests, but I haven't yet. It does work in the pipeline that motivated it (breaking the above into months, some of which chng has no data).

[codecov-commenter]

Codecov Report

❗ No coverage uploaded for pull request base (dev@f121d72). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 4ad7379 differs from pull request most recent head cfe5521. Consider uploading reports for the commit cfe5521 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@          Coverage Diff           @@
##             dev     #132   +/-   ##
======================================
  Coverage       ?   95.37%           
======================================
  Files          ?        8           
  Lines          ?     1168           
  Branches       ?        0           
======================================
  Hits           ?     1114           
  Misses         ?       54           
  Partials       ?        0           

[dshemetov]

looks good!

• tests for timeout_seconds not necessary, since the codepath is still the same
• a single test for return_empty might be good, but up to you, purely a code cov thing

[dshemetov]

#128