A few more fixes for release #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use it in the package, but we don't have to export it. Users can import magrittr or dplyr if they want it, and then it's at least more explicit where it came from.
A vector of entries is much nicer to manipulate programmatically, and is automatically turned into the right query anyway.
capnrefsmmat
requested review from
dshemetov,
brookslogan and
dsweber2
as code owners
dshemetov
approved these changes
Sep 11, 2023
1. cran comments explaining dontrun 2. citations 3. removing some dontruns and/or examples
* rebuild it with `devtools::render_readme()` * easier to track changes / multiple files * Note that the rebuilt figure looks a bit different.
Djm/pkgdown updates
|
Can we merge this so I can build on it in a PR dealing with API keys? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit messages describe the reasoning.