-
Notifications
You must be signed in to change notification settings - Fork 5
fix: improve reading of EPIDATR_USE_CACHE
variable
#273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
Package: epidatr | ||
Type: Package | ||
Title: Client for Delphi's 'Epidata' API | ||
Version: 1.1.3 | ||
Version: 1.1.4 | ||
Authors@R: | ||
c( | ||
person("Logan", "Brooks", email = "[email protected]", role = c("aut")), | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,10 +1,19 @@ | ||||||
# epidatr 1.2.0 | ||||||
|
||||||
## Changes | ||||||
|
||||||
- Improve handling of the `EPIDATR_USE_CACHE` environment variable, allowing it | ||||||
to be any value convertable by `as.logical()` and handle the case when it | ||||||
can't be converted. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: please include PR number here
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ah my bad, I set it up to auto-merge, let's add this in a next PR |
||||||
|
||||||
# epidatr 1.1.1 | ||||||
|
||||||
## Changes | ||||||
|
||||||
## Features | ||||||
|
||||||
## Patches | ||||||
|
||||||
- Fix failure when passing `as_of` values in `Date` format to | ||||||
`pub_covidcast` while caching is enabled (#259). | ||||||
- For `pub_covidcast` data source `nchs-mortality`, parse dates as `epiweek` | ||||||
|
@@ -15,21 +24,26 @@ | |||||
# epidatr 1.1.0 | ||||||
|
||||||
## Changes | ||||||
|
||||||
- `pub_covid_hosp_state_timeseries` now supports use of the `as_of` parameter (#209). | ||||||
- `release_date` and `latest_update` fields are now parsed as `Date`, rather | ||||||
than as text. This change impacts several endpoints. | ||||||
- `get_auth_key` renamed to `get_api_key` (#181). | ||||||
- `get_api_key` no longer reads from R options and only uses environment variables (#217). | ||||||
- `pvt_twitter` and `pub_wiki` now use `time_type` and `time_values` args instead of mutually exclusive `dates` and `epiweeks` (#236). This matches the interface of the `pub_covidcast` endpoint. | ||||||
- Updated the default `timeout_seconds` to 15 minutes to allow large queries by default. | ||||||
|
||||||
## Features | ||||||
|
||||||
- Function reference now displays commonly-used functions first (#205). | ||||||
- Support `Date` objects passed to version arguments `as_of` and `issues` in | ||||||
endpoints (#192, #194). | ||||||
- `clear_cache` now handles positional arguments just like `set_cache` (#197). | ||||||
- `set_api_key` now available to help persist API key environment variables (#181, #217). | ||||||
- All endpoints now support the use of "\*" as a wildcard to fetch all dates or epiweeks (#234). | ||||||
|
||||||
## Patches | ||||||
|
||||||
- Endpoints now fail when passed misspelled arguments (#187, #201). | ||||||
- `pub_fluview_meta` fixed to `fetch` the response automatically. | ||||||
- `pub_covid_hosp_state_timeseries` now correctly parses the `issue` field, | ||||||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.