Skip to content

Fix pvt_twitter and wiki fetch_classic bug #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2022
Merged

Conversation

dshemetov
Copy link
Contributor

@dshemetov dshemetov commented Apr 1, 2022

Fixes #21. Fixes #19. Relied on a bad usage of ifelse, which doesn't do what one would think.

@dshemetov dshemetov requested a review from krivard April 1, 2022 21:45
@krivard
Copy link
Contributor

krivard commented Apr 4, 2022

You have some kind of styler error? I'm not familiar with the build system on this repo yet.

@dshemetov
Copy link
Contributor Author

dshemetov commented Apr 4, 2022

Oof, the build system is a bit annoying, there's a few different linters that need to be made happy and I'm not sure how to replicate them in my IDE yet. Think I fixed it though.

Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@dshemetov dshemetov merged commit 9ddfa52 into dev Apr 4, 2022
@dshemetov dshemetov deleted the ds/fix-ifelse-bug branch April 4, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wiki fails when calling fetch_classic pvt_twitter fails when using fetch_classic
2 participants