Skip to content

Use inds1, inds2 smartly in vec_approx_equal, or remove #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brookslogan opened this issue Mar 26, 2025 · 0 comments
Open

Use inds1, inds2 smartly in vec_approx_equal, or remove #641

brookslogan opened this issue Mar 26, 2025 · 0 comments

Comments

@brookslogan
Copy link
Contributor

brookslogan commented Mar 26, 2025

If it continues to look like a major time contributor in major operations.

For data frames, we don't have to slice as much of later columns if an early column has already determined the result for a given entry to be FALSE or NA. We don't even need to slice later columns at all if the earlier entries have already determined the results for all entries. If this provides a substantial speed-up, we should compare speed vs. vec_equal and determine whether to use it in the abs_tol == 0 data frame case rather than vec_equal.

This was the original idea behind these arguments, but was never actually implemented. These args coincidentally provided a speedup as the implementation used vec_slice instead of df[<row indices>,]. If we can't actually improve performance in a real way using these args, they can be removed to simplify the interface and code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant