Avoid filter(cases==1), better describe & complete Ebola example
#260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajmcdon
approved these changes
May 25, 2023
brookslogan
force-pushed
the
lcb/clarify-ebola-example-code
branch
from
15a6023 to
b0c2317
Compare
brookslogan
force-pushed
the
lcb/clarify-ebola-example-code
branch
from
b0c2317 to
d14ee3f
Compare
|
Finally getting around to revisiting this. I thought there was something else to do here, but apparently there was only styling left? I've held off on converting things to use |
Avoid `filter(cases==1)`: this should either * involve `filter(status == "confirmed")` instead, or * involve no filter, and let `sum` take care of things. We should generally expect the latter approach to be RAM-friendlier (one new column vs. new filtered vectors for every column), so implement the latter approach. Reformat the code a bit to try to make it read better. Clarify the description of the example; make clear we're deriving from line list data. `complete` the data to make the set of `time_value`s evenly spaced and the same for every `geo_value`; even though it doesn't impact the plots, we're demonstrating how to get things into `epi_df` format, and many functions we'd use on `epi_df`s will expect things in this format.
brookslogan
force-pushed
the
lcb/clarify-ebola-example-code
branch
from
d14ee3f to
9417d33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid
filter(cases==1): this should eitherfilter(status == "confirmed")instead, orsumtake care of things.We should generally expect the latter approach to be RAM-friendlier (one new column vs. new filtered vectors for every column), so implement the latter approach.
Reformat the code a bit to try to make it read better.
Clarify the description of the example; make clear we're deriving from line list data.
completethe data to make the set oftime_values evenly spaced and the same for everygeo_value; even though it doesn't impact the plots, we're demonstrating how to get things intoepi_dfformat, and many functions we'd use onepi_dfs will expect things in this format.