Skip to content

feat: supply tidyselection for sum_groups_epi_df #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 10, 2025

Conversation

dajmcdon
Copy link
Contributor

@dajmcdon dajmcdon commented Apr 8, 2025

Checklist

Please:

  • Make sure this PR is against "dev", not "main" (unless this is a release
    PR).
  • Request a review from one of the current main reviewers:
    brookslogan, nmdefries.
  • Makes sure to bump the version number in DESCRIPTION. Always increment
    the patch version number (the third number), unless you are making a
    release PR from dev to main, in which case increment the minor version
    number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    1.7.2, then write your changes under the 1.8 heading).

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

@dajmcdon dajmcdon linked an issue Apr 8, 2025 that may be closed by this pull request
Copy link
Contributor

@brookslogan brookslogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some tweaks to the roxygen. @dshemetov , this has the potential to raise warnings or, in very unlikely unfortunate cases, change behavior, in forecast production.

  • The changed behavior would be if you did x %>% sum_groups_epi_df(my_vars, .....) and x happened to have a column named my_vars.
  • Warnings would be if you did the above but x luckily didn't have a column named my_vars and so it realized it should look at the variable my_vars.
  • Resolution is to move to all_of(my_vars) or !!my_vars.

I'll leave it to you to control the merge time in light of the above.

@dshemetov dshemetov merged commit e08a693 into dev Apr 10, 2025
3 checks passed
@dshemetov dshemetov deleted the 655-sum_groups_epi_df-tidyselection branch April 10, 2025 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alter sum_groups_epi_df() to take tidyselection instead of chr vctr
3 participants