-
Notifications
You must be signed in to change notification settings - Fork 8
Revision summary printing #658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some fixes, but generally happy to see this.
There were some objects where you were referencing at the wrong depth when printing, which was changing the "No revision" count.
Thanks! I want to do one other thing, which is to move the args that apply only to printing to the print method. But I'm having difficulty figuring out what |
Merge branch 'revision-summary-printing' of https://github.com/cmu-delphi/epiprocess into revision-summary-printing # Conflicts: # R/revision_analysis.R
The idea with |
@dsweber2 Does this still look ok after my changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, lgtm!
Checklist
Please:
PR).
brookslogan, nmdefries.
DESCRIPTION
. Always incrementthe patch version number (the third number), unless you are making a
release PR from dev to main, in which case increment the minor version
number (the second number).
(backwards-incompatible changes to the documented interface) are noted.
Collect the changes under the next release number (e.g. if you are on
1.7.2, then write your changes under the 1.8 heading).
/document
to check the package documentation and fix any issues./style
to check the style and fix any issues./preview-docs
to preview the docs.process.
Change explanations for reviewer
@dsweber2 I wanted to improve the printing behavior of
revision_summary()
. How does this look to you?